KH2: client optimizations and some more qol #4547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
qwint
suggested changes
Jan 24, 2025
There was a problem hiding this comment.
just reviewed the changes per my request, don't have context to review the read_bytes update nor the openKH data changes
pure code review
mostly some small formatting requests but the connect_to_game() comment I think should be tested and proven not an issue or addressed
Co-authored-by: qwint <[email protected]>
…ike/Archipelago into kh2-optimize-client
qwint
reviewed
Jan 26, 2025
qwint
approved these changes
Jan 27, 2025
|
|
shananas
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Addressing qwint's suggestions on #4075
Having the random/yaml settings show up in game
How was this tested?
tested what happens if there is no datapackage/if it were an empty dict
read the yaml after generation for the seed and it was formatted correctly
If this makes graphical changes, please attach screenshots.