Core: Cleanup: Replace direct calling of dunder methods on objects #4584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Calling the dunder method has to:
Whereas running the appropriate operation on the object from the start skips straight to step 4.
Region.Register.__getitem__
is called a lot without #4583. In that case, generation of 10 template Blasphemous yamls with--skip_output --seed 1
and progression balancing disabled went from 19.0s to 18.8s (1.3% reduction in generation duration).From profiling with
timeit
appears to be about twice as fast as the old code:
Besides this, there is not expected to be any noticeable difference in performance, and there is not expected to be any difference in semantics with these changes.
How was this tested?
Ran generations before and after