Skip to content

Commit

Permalink
refactor: persist errors on send form (#441)
Browse files Browse the repository at this point in the history
  • Loading branch information
patricio0312rev authored Jul 16, 2024
1 parent 728045e commit d11f88a
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
10 changes: 9 additions & 1 deletion src/components/send/SendForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ export const SendForm = ({ formik }: { formik: FormikProps<SendFormik> }) => {
formik.validateField('amount');
};

const handleAmountInputChange = (event: React.ChangeEvent<HTMLInputElement>) => {
const { value } = event.target;
if (constants.FEE_REGEX.test(value) || value === '') {
formik.setFieldValue('amount', value.trim());
formik.validateField('amount');
}
};

const handleFeeInputChange = (event: React.ChangeEvent<HTMLInputElement>) => {
if (!constants.FEE_REGEX.test(event.target.value)) {
return;
Expand Down Expand Up @@ -90,7 +98,7 @@ export const SendForm = ({ formik }: { formik: FormikProps<SendFormik> }) => {
</button>
}
value={formik.values.amount}
onChange={handleInputChange}
onChange={handleAmountInputChange}
onBlur={formik.handleBlur}
variant={
formik.errors.amount && formik.values.amount !== '' ? 'destructive' : 'primary'
Expand Down
13 changes: 12 additions & 1 deletion src/pages/Send.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export type SendFormik = {
fee: string;
receiverAddress: string;
feeClass?: string;
errors?: any;
};

interface PageData extends SendFormik {
Expand Down Expand Up @@ -197,7 +198,7 @@ const Send = () => {
runtime.sendMessage({
type: 'SET_LAST_SCREEN',
path: ScreenName.SendTransfer,
data: formik.values,
data: { errors: formik.errors, ...formik.values },
});

return () => {
Expand All @@ -212,6 +213,16 @@ const Send = () => {
setIsModalOpen(true);
};

useEffect(() => {
const { data } = lastVisitedPage || {};
if (data?.errors && Object.keys(data.errors).length > 0) {
formik.setErrors(data.errors);
Object.entries(data.errors).forEach(([key]) => {
formik.setFieldTouched(key, true);
});
}
}, [lastVisitedPage, formik.setFieldTouched, formik.setErrors]);

return (
<SubPageLayout
title={t('COMMON.SEND')}
Expand Down

0 comments on commit d11f88a

Please sign in to comment.