Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(world-cli): Add a sample test and fix a bug with the docker daemon check #14

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

jerargus
Copy link
Contributor

What is the purpose of the change

Add a sample test to show how to capture the standard out and standard error for tests.

Testing and Verifying

run go test ./... from the root directory to see this test in action.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (159fc27) 0.00% compared to head (41cd7fc) 23.52%.

❗ Current head 41cd7fc differs from pull request most recent head 8b13016. Consider uploading reports for the commit 8b13016 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           main      #14       +/-   ##
=========================================
+ Coverage      0   23.52%   +23.52%     
=========================================
  Files         0        3        +3     
  Lines         0       51       +51     
=========================================
+ Hits          0       12       +12     
- Misses        0       39       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smsunarto
Copy link
Member

smsunarto commented Nov 14, 2023

@jerargus while we are at this, i think we should add a go and/or docker dependency to the world cardinal subcommand. These subcommand doesn't use bubbletea, so we would should extract https://github.com/Argus-Labs/world-cli/blob/main/common/tea_cmd/dependencies.go#L64-L78 into a function we can directly call without tea.Cmd/Msg wrapper

@jerargus jerargus closed this Nov 14, 2023
@jerargus jerargus reopened this Nov 15, 2023
@jerargus jerargus merged commit fd8c647 into main Nov 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants