Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check dir is exists before create/clone on world cardinal create command #83

Merged
merged 1 commit into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. fix: check dir is exists before create/clone on world cardinal create…

    … command (#83)
    
    Closes: WORLD-1044
    
    ## Overview
    
    if you world create with name == "foobar" and you already have a dir named "foobar", the error message you get isn't very helpful.
    
    ## Brief Changelog
    
    - add checking for the exists dir before doing clone
    
    ## Testing and Verifying
    
    - Manually tested using `world cardinal create` command
    - Adjusted unit test
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai -->
    ## Summary by CodeRabbit
    
    - **Bug Fixes**
    	- Enhanced error handling in the Git clone operation to prevent overwriting existing directories by returning an error if the target directory already exists.
    - **Tests**
    	- Updated test cases to utilize a new directory structure for command execution, ensuring consistent behavior in command tests.
    	- Modified the `TestBuild` function to clone repositories into a specific subdirectory within the test environment.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    zulkhair committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    64feb1f View commit details
    Browse the repository at this point in the history