Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cardinal)!: rename Transaction/TransactionType to Message/MessageType #396

Merged

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Nov 6, 2023

NOTE

im going to leave the TransactionQueue as it is currently named. Would change it to MessageQueue if it only contained messages, but i believe Transaction takes precedence here

What is the purpose of the change

renames cardinal's Transaction types to Message.

Brief Changelog

Testing and Verifying

run cardinal unit tests.

Copy link

github-actions bot commented Nov 6, 2023

World Engine Docs deployed to Vercel (Preview)!


🔍 Inspect: https://vercel.com/argus-labs/world-engine-docs/4CepSb2rzgzXS8htpigJ3vs3MCfp [4s]
🌐 Preview: https://world-engine-docs-jvafo8riv-argus-labs.vercel.app

@technicallyty technicallyty changed the title Tyler/world 501 rename cardinals transaction to message refactor(cardinal): rename Transaction/TransactionType to Message/MessageType Nov 6, 2023
@technicallyty technicallyty changed the title refactor(cardinal): rename Transaction/TransactionType to Message/MessageType refactor(cardinal)!: rename Transaction/TransactionType to Message/MessageType Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #396 (679f7d2) into main (aae93a8) will decrease coverage by 0.01%.
The diff coverage is 73.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   64.49%   64.49%   -0.01%     
==========================================
  Files          82       82              
  Lines        4645     4647       +2     
==========================================
+ Hits         2996     2997       +1     
- Misses       1323     1324       +1     
  Partials      326      326              
Files Coverage Δ
cardinal/ecs/cql/cql.go 28.24% <ø> (ø)
cardinal/ecs/ecb/tick.go 64.28% <100.00%> (ø)
cardinal/ecs/message/queue.go 84.78% <100.00%> (ø)
cardinal/ecs/receipt/receipt.go 92.59% <100.00%> (ø)
cardinal/ecs/world_context.go 95.12% <100.00%> (ø)
cardinal/evm/server.go 41.23% <100.00%> (ø)
cardinal/server/server.go 67.78% <100.00%> (ø)
cardinal/server/tx.go 66.00% <100.00%> (ø)
cardinal/server/utils.go 52.05% <100.00%> (ø)
cardinal/util.go 100.00% <100.00%> (ø)
... and 7 more

@technicallyty technicallyty marked this pull request as ready for review November 7, 2023 18:48
@technicallyty technicallyty requested a review from a team as a code owner November 7, 2023 18:48
cardinal/ecs/world.go Outdated Show resolved Hide resolved
@technicallyty technicallyty enabled auto-merge (squash) November 8, 2023 19:08
@technicallyty technicallyty merged commit f681fd0 into main Nov 8, 2023
8 checks passed
@technicallyty technicallyty deleted the tyler/world-501-rename-cardinals-transaction-to-message branch November 8, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants