-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cardinal)!: rename Transaction/TransactionType to Message/MessageType #396
Merged
technicallyty
merged 28 commits into
main
from
tyler/world-501-rename-cardinals-transaction-to-message
Nov 8, 2023
Merged
refactor(cardinal)!: rename Transaction/TransactionType to Message/MessageType #396
technicallyty
merged 28 commits into
main
from
tyler/world-501-rename-cardinals-transaction-to-message
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
World Engine Docs deployed to Vercel (Preview)!🔍 Inspect: https://vercel.com/argus-labs/world-engine-docs/4CepSb2rzgzXS8htpigJ3vs3MCfp [4s] |
technicallyty
changed the title
Tyler/world 501 rename cardinals transaction to message
refactor(cardinal): rename Transaction/TransactionType to Message/MessageType
Nov 6, 2023
technicallyty
changed the title
refactor(cardinal): rename Transaction/TransactionType to Message/MessageType
refactor(cardinal)!: rename Transaction/TransactionType to Message/MessageType
Nov 6, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 64.49% 64.49% -0.01%
==========================================
Files 82 82
Lines 4645 4647 +2
==========================================
+ Hits 2996 2997 +1
- Misses 1323 1324 +1
Partials 326 326
|
jerargus
approved these changes
Nov 7, 2023
technicallyty
deleted the
tyler/world-501-rename-cardinals-transaction-to-message
branch
November 8, 2023 20:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
im going to leave the TransactionQueue as it is currently named. Would change it to MessageQueue if it only contained messages, but i believe Transaction takes precedence here
What is the purpose of the change
renames cardinal's Transaction types to Message.
Brief Changelog
Testing and Verifying
run cardinal unit tests.