Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cardinal): allow cors on dev mode #403

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

pyrofolium
Copy link
Contributor

Closes: #500

What is the purpose of the change

Allow CORS as an option for servers.

Testing and Verifying

Added an additional check to an existing test

@pyrofolium pyrofolium requested a review from a team as a code owner November 7, 2023 22:38
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #403 (57edb6e) into main (f92d50d) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   64.32%   64.48%   +0.15%     
==========================================
  Files          82       82              
  Lines        4631     4643      +12     
==========================================
+ Hits         2979     2994      +15     
+ Misses       1325     1323       -2     
+ Partials      327      326       -1     
Files Coverage Δ
cardinal/option.go 100.00% <100.00%> (ø)
cardinal/server/option.go 100.00% <100.00%> (ø)
cardinal/server/server.go 67.78% <100.00%> (+0.88%) ⬆️

... and 1 file with indirect coverage changes

cardinal/option.go Outdated Show resolved Hide resolved
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyrofolium pyrofolium merged commit d63eaaa into main Nov 8, 2023
5 checks passed
@pyrofolium pyrofolium deleted the brian/world-500-allow-cors-on-dev-mode branch November 8, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants