chore(chain): base shard script hardening & faucet address loading (WORLD-471, WORLD-469) #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 64.63% 64.63%
=======================================
Files 82 82
Lines 4660 4660
=======================================
Hits 3012 3012
Misses 1318 1318
Partials 330 330
|
technicallyty
force-pushed
the
tyler/world-471-evm-base-shard-start-up-script-dx
branch
from
b4c91e5
to
3854cfd
Compare
namrapatel
approved these changes
Nov 9, 2023
technicallyty
changed the title
technicallyty
deleted the
tyler/world-471-evm-base-shard-start-up-script-dx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
All previously hard-coded values are now defaults, and overridden by env variables.
Updated the chain's README to reflect current state.
Added a new env var FAUCET_ADDR, that keeps the given address topped up with EVM funds.
renamed scripts, they're now ->>
start-sequencer.shandstart-celestia-devnet.sh.simplified script flow
Testing and Verifying
manually