refactor(cardinal): register query with generics #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
- Coverage 64.78% 64.71% -0.07%
==========================================
Files 82 81 -1
Lines 4682 4713 +31
==========================================
+ Hits 3033 3050 +17
- Misses 1315 1329 +14
Partials 334 334
|
smsunarto
force-pushed
the
11-08-refactor_upstream_config_and_refactor_NewWorld
branch
from
cb0f00a
to
4c480dd
Compare
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
from
d4f19a0
to
b7e044f
Compare
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
from
b7e044f
to
c6d27dd
Compare
smsunarto
force-pushed
the
11-08-refactor_upstream_config_and_refactor_NewWorld
branch
from
4fc6230
to
8dd7401
Compare
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
2 times, most recently
from
f24e962
to
237270f
Compare
smsunarto
force-pushed
the
11-08-refactor_upstream_config_and_refactor_NewWorld
branch
from
8a543c3
to
ef33794
Compare
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
4 times, most recently
from
2242ded
to
b71e3a5
Compare
smsunarto
force-pushed
the
11-08-refactor_upstream_config_and_refactor_NewWorld
branch
from
2a146b2
to
62cc6db
Compare
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
3 times, most recently
from
7c3c439
to
73f0685
Compare
smsunarto
force-pushed
the
11-08-refactor_upstream_config_and_refactor_NewWorld
branch
2 times, most recently
from
c18cd7f
to
991914e
Compare
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
2 times, most recently
from
860386e
to
786b65d
Compare
Base automatically changed from
11-08-refactor_upstream_config_and_refactor_NewWorld
to
main
November 13, 2023 20:48
Merge activity
|
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
from
786b65d
to
37d3072
Compare
jerargus
approved these changes
Nov 13, 2023
technicallyty
approved these changes
Nov 13, 2023
technicallyty
approved these changes
Nov 13, 2023
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
from
37d3072
to
2640d03
Compare
|
gdi, stop merging in front of me |
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
from
2640d03
to
44e710d
Compare
smsunarto
force-pushed
the
11-08-refactor_register_query
branch
from
44e710d
to
622b1dd
Compare
|
fuck e2e tests, all my homies hate the e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Making register query more consistent with register component
Brief Changelog
Testing and Verifying