Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newcontextmovetestme #760

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ jobs:
uses: actions/setup-go@v5
with:
go-version: ${{ env.GO_VERSION }}
## skip cache, use Namespace volume cache
cache: false
cache: true
cache-dependency-path: "**/*.sum"
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Run swagger-check
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

- (cardinal) #WORLD-702: Cardinal's transactions are now sent at the end of a tick, instead of one by one at the server handler.

- (nakama) GDEV-1024: Nakama will automatically attempt to reconnect a websocket when cardinal is restarted.

### Deprecated

### Bug Fixes
Expand Down
5 changes: 2 additions & 3 deletions cardinal/benchmark/benchmark_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"pkg.world.dev/world-engine/cardinal/search/filter"
"pkg.world.dev/world-engine/cardinal/testutils"
"pkg.world.dev/world-engine/cardinal/types"
"pkg.world.dev/world-engine/cardinal/types/engine"
)

type Health struct {
Expand All @@ -25,7 +24,7 @@ func (Health) Name() string {
}

// setupWorld Creates a new *cardinal.World and initializes the world to have numOfEntities already cardinal.Created. If
// enableHealthSystem is set, a System will be added to the world that increments every entity's "health" by 1 every
// enableHealthSystem is set, a system will be added to the world that increments every entity's "health" by 1 every
// tick.
func setupWorld(t testing.TB, numOfEntities int, enableHealthSystem bool) *testutils.TestFixture {
tf := testutils.NewTestFixture(t, nil)
Expand All @@ -35,7 +34,7 @@ func setupWorld(t testing.TB, numOfEntities int, enableHealthSystem bool) *testu
if enableHealthSystem {
err := cardinal.RegisterSystems(
world,
func(wCtx engine.Context) error {
func(wCtx cardinal.WorldContext) error {
q := cardinal.NewSearch().Entity(filter.Contains(filter.Component[Health]()))
err := q.Each(wCtx,
func(id types.EntityID) bool {
Expand Down
Loading
Loading