-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cardinal): privatize internal methods on context. #762
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 59.89% 59.85% -0.05%
==========================================
Files 141 140 -1
Lines 7214 7231 +17
==========================================
+ Hits 4321 4328 +7
- Misses 2452 2458 +6
- Partials 441 445 +4
|
As stated in the description, made this PR to get a PR where every commit is signed. This is identical to the old context PR: #757 |
Closes: WORLD-1112
This is a replica of #757
With all commits squashed into one. This is done because this repo requires all commits getting pushed to be signed. I could force push but that would rewrite the entire conversation located in that PR. In order to preserver history I am making this second PR.
Overview
See the other PR link above for more details.