Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript and 1.0 #34

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Typescript and 1.0 #34

wants to merge 47 commits into from

Conversation

Arilas
Copy link
Owner

@Arilas Arilas commented May 9, 2019

TODO:

Write TODO

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #34 into master will decrease coverage by 1.83%.
The diff coverage is 85.35%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #34      +/-   ##
=========================================
- Coverage   89.53%   87.7%   -1.84%     
=========================================
  Files          29      41      +12     
  Lines         497     618     +121     
  Branches       72      98      +26     
=========================================
+ Hits          445     542      +97     
- Misses         48      73      +25     
+ Partials        4       3       -1
Impacted Files Coverage Δ
packages/schema-tool/src/constants.ts 100% <ø> (ø)
...s/schema-tool/src/gateways/async/executeGateway.ts 100% <ø> (ø)
...ckages/schema-tool/src/gateways/async/constants.ts 100% <ø> (ø)
packages/schema-tool/src/createSchemaTool.ts 100% <ø> (ø)
...ges/schema-tool/src/gateways/async/queryGateway.ts 100% <ø> (ø)
packages/schema-tool/src/gateways/addSqlGateway.ts 50% <ø> (ø)
...ages/schema-tool/src/gateways/createBaseGateway.ts 77.77% <ø> (ø)
packages/schema-tool/src/initMinormSchema.ts 100% <ø> (ø)
...kages/schema-tool/src/gateways/dropTableGateway.ts 100% <ø> (ø)
packages/core/src/manager/index.ts 100% <100%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924c093...d0e0e3e. Read the comment docs.

@Arilas
Copy link
Owner Author

Arilas commented May 11, 2019

TODO:

  • createManager to manager folder
  • Extract queryBuilder to own creator, so createManager can be extendable
  • Refactor repository creators in a way how it's done with managers using creators and composing
  • Add createRepository to repository folder
  • Move metadata manager to their own folder from utils
  • Fix mapper issue with left join results. If record is not found, it will return object with all fields and null values, should check for id null
  • Refactor schema tool and remove hardcode related to MySQL. Schema tool should use data types from adapter the same should be applied for table engines and encoding
  • Add flavor flag to adapter so we can use sequel.useFlavor() call to include all database features
  • Implement @minorm/adapter-fake that can be used in unit tests. It's can be extracted from current core tests
  • Write complete API documentation for core module with examples
  • Rename SomeRecord to EntityBaseInterface
  • Rename BaseRecord to AbstractEntity
  • Make all typings exportable
  • Increase test coverage. Unit and Integration tests coverage should be almost the same.

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant