feat: Enable overriding executor timeouts per model #6206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mikeldking
reviewed
Jan 31, 2025
| @property | ||
| def _timeout(self) -> Optional[int]: | ||
| if "o1" in self.model: | ||
| return 240 |
There was a problem hiding this comment.
this number seems somewhat arbitrary? you can't set the timeout on the model itself?
There was a problem hiding this comment.
I would love a timeout on the model itself. o1 can think for longer than 240 seconds with a high reasoning effort.
There was a problem hiding this comment.
that's a good idea!
mikeldking
approved these changes
Jan 31, 2025
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6198
Enables a timeout override for
AsyncExecutors on a per-model basis. Some model wrappers now have an optionaltimeoutargument that will override the internal timeout of 120s.This original 120s timeout was determined to "feel good" when doing our initial internal throttler testing.