Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core sdk tests) #311

Merged
merged 19 commits into from
Mar 12, 2024
Merged

fix(core sdk tests) #311

merged 19 commits into from
Mar 12, 2024

Conversation

ybensacq
Copy link
Contributor

@ybensacq ybensacq commented Mar 5, 2024

Description

Fix Core SDK tests

What type of PR is this? (check all applicable)

  • βœ… Test (test:)

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Documentation
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

@ybensacq ybensacq linked an issue Mar 5, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Mar 5, 2024

⚠️ No Changeset found

Latest commit: 3143144

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ark-project-sdk-demo βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 12, 2024 2:13pm

@ybensacq ybensacq changed the title 245 fix core sdk tests for each case fix(core sdk tests) Mar 5, 2024
@ybensacq ybensacq requested a review from kwiss March 5, 2024 13:42
@ybensacq ybensacq force-pushed the 245-fix-core-sdk-tests-for-each-case branch from 39d6074 to c87dc40 Compare March 5, 2024 13:45
@ybensacq ybensacq force-pushed the 245-fix-core-sdk-tests-for-each-case branch from c87dc40 to 21160f8 Compare March 6, 2024 08:02
@kwiss kwiss merged commit 5b80757 into main Mar 12, 2024
8 checks passed
@kwiss kwiss deleted the 245-fix-core-sdk-tests-for-each-case branch March 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix core sdk tests for each case
2 participants