Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(orderbook): contract add cancel event and reason #323

Merged
merged 7 commits into from
Mar 23, 2024
Merged

feat(orderbook): contract add cancel event and reason #323

merged 7 commits into from
Mar 23, 2024

Conversation

ybensacq
Copy link
Contributor

@ybensacq ybensacq commented Mar 20, 2024 •
edited
Loading

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature (feat:)
  • 🐛 Bug Fix (fix:)
  • 📝 Documentation Update (docs:)
  • 🎨 Style (style:)
  • 🧑‍💻 Code Refactor (refactor:)
  • 🔥 Performance Improvements (perf:)
  • ✅ Test (test:)
  • 🤖 Build (build:)
  • 🔁 CI (ci:)
  • 📦 Chore (chore:)
  • ⏩ Revert (revert:)
  • 🚀 Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Documentation
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

fix #319

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9ff0ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ark-project-sdk-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2024 11:14pm

kwiss
kwiss reviewed Mar 21, 2024
View reviewed changes
contracts/ark_orderbook/src/orderbook.cairo Outdated
Comment on lines 290 to 294
ref self: ContractState, _from_address: felt252, order_hash: felt252, reason: felt252
) {
order_status_write(order_hash, OrderStatus::Open);
self.emit(OrderCancelled { order_hash, reason: reason.into() });
self.emit(OrderBackToOpen { order_hash });
Copy link
Contributor

@kwiss kwiss Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really a cancel ? maybe it's more a rollbackStatus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes right, then we remove OrderCancelled event and we rename OrderBackToOpen and we add another parameter.

@ybensacq ybensacq force-pushed the 319-orderbook-contract-add-event-and-reason branch from cc2ada5 to 7c490be Compare March 23, 2024 01:09
@ybensacq ybensacq force-pushed the 315-implementing-fee-distribution-on-token-swap-in-starknet-contract branch from 998066a to 6ed4216 Compare March 23, 2024 23:05
@ybensacq ybensacq force-pushed the 319-orderbook-contract-add-event-and-reason branch from 7c490be to 461b3f2 Compare March 23, 2024 23:10
@kwiss kwiss merged commit bfcc515 into 315-implementing-fee-distribution-on-token-swap-in-starknet-contract Mar 23, 2024
8 checks passed
@kwiss kwiss deleted the 319-orderbook-contract-add-event-and-reason branch March 23, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwiss kwiss kwiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybensacq @kwiss