Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x #440

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

2.x #440

wants to merge 73 commits into from

Conversation

kwiss
Copy link
Contributor

@kwiss kwiss commented Sep 9, 2024

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature (feat:)
  • πŸ› Bug Fix (fix:)
  • πŸ“ Documentation Update (docs:)
  • 🎨 Style (style:)
  • πŸ§‘β€πŸ’» Code Refactor (refactor:)
  • πŸ”₯ Performance Improvements (perf:)
  • βœ… Test (test:)
  • πŸ€– Build (build:)
  • πŸ” CI (ci:)
  • πŸ“¦ Chore (chore:)
  • ⏩ Revert (revert:)
  • πŸš€ Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ Documentation
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

  • Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
  • Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
  • Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

Copy link

changeset-bot bot commented Sep 9, 2024

πŸ¦‹ Changeset detected

Latest commit: 2ca0228

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kwiss and others added 28 commits September 9, 2024 12:54
…ook on (#439)

## Description

1. Orderbook is now a component
2. Remove messaging in Starknet part
3. Add `version` and `order_type` in Orderbook component events
4. Move dependencies version to workspace Scarb.toml
5. Update to cairo 2.7.1, snforge 0.28 & OZ 0.15.1

<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?

For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->

## What type of PR is this? (check all applicable)

- [x] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [ ] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [ ] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [ ] πŸ™… no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?

<!-- Describe any additional tasks, if any, and provide steps. -->

## [optional] What gif best describes this PR or how it makes you feel?

<!-- Share a fun gif related to your PR! -->

### PR Title and Description Guidelines:

- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).

## Closing Issues

<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
## Description

<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?

For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->

## What type of PR is this? (check all applicable)

- [ ] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [ ] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [ ] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [ ] πŸ™… no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?

<!-- Describe any additional tasks, if any, and provide steps. -->

## [optional] What gif best describes this PR or how it makes you feel?

<!-- Share a fun gif related to your PR! -->

### PR Title and Description Guidelines:

- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).

## Closing Issues

<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
## Description

<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?

For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->

## What type of PR is this? (check all applicable)

- [ ] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [ ] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [ ] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [ ] πŸ™… no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?

<!-- Describe any additional tasks, if any, and provide steps. -->

## [optional] What gif best describes this PR or how it makes you feel?

<!-- Share a fun gif related to your PR! -->

### PR Title and Description Guidelines:

- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).

## Closing Issues

<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
## Description

- update broken tests
- remove timeouts

## What type of PR is this? (check all applicable)

- [ ] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [x] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)
## Description

Allow tests to be run in project root.
## Description

Simplify core function and react hooks parameters.

Before:

```ts
const orderHash = await createOffer(config, {
  starknetAccount: buyer,
  offer: {
    brokerId: accounts.listingBroker.address,
    tokenAddress: STARKNET_NFT_ADDRESS,
    tokenId,
    startAmount: BigInt(10)
  },
  approveInfo: {
    currencyAddress: config.starknetCurrencyContract,
    amount: BigInt(10)
  }
});
```

After:

```ts
const { orderHash } = await createOffer(config, {
  account: buyer,
  brokerAddress: accounts.listingBroker.address,
  currencyAddress: config.starknetCurrencyContract,
  tokenAddress,
  tokenId,
  amount: BigInt(10)
});
```


## What type of PR is this? (check all applicable)

- [ ] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [ ] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [ ] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [ ] πŸ™… no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?

<!-- Describe any additional tasks, if any, and provide steps. -->

## [optional] What gif best describes this PR or how it makes you feel?

<!-- Share a fun gif related to your PR! -->

### PR Title and Description Guidelines:

- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).

## Closing Issues

<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
## Description

Add sdk react hook tests.

## What type of PR is this? (check all applicable)

- [ ] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [x] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)
## Description

Add collection offer in sdk core and react.

## What type of PR is this? (check all applicable)

- [x] πŸ• Feature (`feat:`)

## Added tests?

- [x] πŸ‘ yes

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [x] πŸ™… no documentation needed
## Description

- fix cyclic dependency between @ark-project/core and @ark-project/test
- use vitest for core tests (already used for react tests)

## What type of PR is this? (check all applicable)

- [ ] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [x] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)
@kwiss kwiss marked this pull request as ready for review October 10, 2024 09:14
manlikeHB and others added 12 commits October 10, 2024 16:31
## Description
This PR extends the existing NFT orderbook smart contract to add support
for the ERC-1155 token standard

- [x] ERC-1155 token contract successfully deployed on devnet
- [x] Orderbook smart contract updated to support ERC-1155 tokens
- [x] All existing ERC-721 functionality remains intact
- [x] New ERC-1155 specific functions are implemented and tested
- [x] Quantity handling is correctly implemented for ERC-1155 tokens
- [x] All tests pass, including new tests for ERC-1155 functionality
- [x] PR must be made with the branch
https://github.com/ArkProjectNFTs/ark-project/tree/feat/contract-v2 as a
base

<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?

For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->

## What type of PR is this? (check all applicable)

- [x] πŸ• Feature (`feat:`)
- [x] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [x] βœ… Test (`test:`)
- [x] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [x] πŸ‘ yes

## Added to documentation?

- [x] πŸ“œ README.md

## Closing Issues
Closes #190
<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
## Description
- Create `orderbook` package to handle smart contract event parsing.
- Remove unused crates from Cargo.toml

<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?

For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->

## What type of PR is this? (check all applicable)

- [x] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [x] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [ ] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [ ] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [ ] πŸ™… no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?

<!-- Describe any additional tasks, if any, and provide steps. -->

## [optional] What gif best describes this PR or how it makes you feel?

<!-- Share a fun gif related to your PR! -->

### PR Title and Description Guidelines:

- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).

## Closing Issues

<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
## Description

This PR adds custom error handling to this project by defining several
new error types. These errors are defined in the
packages/core/src/errors directory.

## What type of PR is this? (check all applicable)

- [x] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [ ] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents
Fixes #468

## Added tests?

- [x] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help


## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [x] πŸ™… no documentation needed
#486)

## Description

- Add missing emit of `OrderCancelled` event when an order is cancelled
by a new one.
- Fix local deployment
- SDK: add missing `quantity` field in `FulfillInfo`

<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?

For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->

## What type of PR is this? (check all applicable)

- [ ] πŸ• Feature (`feat:`)
- [x] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [x] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [x] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [ ] πŸ™… no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?

<!-- Describe any additional tasks, if any, and provide steps. -->

## [optional] What gif best describes this PR or how it makes you feel?

<!-- Share a fun gif related to your PR! -->

### PR Title and Description Guidelines:

- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).

## Closing Issues

<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ark-book ❌ Failed (Inspect) Dec 3, 2024 1:24am

## Description
Add public enums for `OrderType` and `RouteType`

<!--
Please do not leave this blank.
Describe the changes in this PR. What does it [add/remove/fix/replace]?

For crafting a good description, consider using ChatGPT to help
articulate your changes.
-->

## What type of PR is this? (check all applicable)

- [x] πŸ• Feature (`feat:`)
- [ ] πŸ› Bug Fix (`fix:`)
- [ ] πŸ“ Documentation Update (`docs:`)
- [ ] 🎨 Style (`style:`)
- [ ] πŸ§‘β€πŸ’» Code Refactor (`refactor:`)
- [ ] πŸ”₯ Performance Improvements (`perf:`)
- [ ] βœ… Test (`test:`)
- [ ] πŸ€– Build (`build:`)
- [ ] πŸ” CI (`ci:`)
- [ ] πŸ“¦ Chore (`chore:`)
- [ ] ⏩ Revert (`revert:`)
- [ ] πŸš€ Breaking Changes (`BREAKING CHANGE:`)

## Related Tickets & Documents

<!--
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [ ] πŸ‘ yes
- [ ] πŸ™… no, because they aren't needed
- [ ] πŸ™‹ no, because I need help

## Added to documentation?

- [ ] πŸ“œ README.md
- [ ] πŸ““ Documentation
- [ ] πŸ™… no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?

<!-- Describe any additional tasks, if any, and provide steps. -->

## [optional] What gif best describes this PR or how it makes you feel?

<!-- Share a fun gif related to your PR! -->

### PR Title and Description Guidelines:

- Ensure your PR title follows semantic versioning standards. This helps
automate releases and changelogs.
- Use types like `feat:`, `fix:`, `chore:`, `BREAKING CHANGE:` etc. in
your PR title.
- Your PR title will be used as a commit message when merging. Make sure
it adheres to [Conventional Commits
standards](https://www.conventionalcommits.org/).

## Closing Issues

<!--
Use keywords to close related issues. This ensures that the associated
issues will automatically close when the PR is merged.

- `Fixes #123` will close issue 123 when the PR is merged.
- `Closes #123` will also close issue 123 when the PR is merged.
- `Resolves #123` will also close issue 123 when the PR is merged.

You can also use multiple keywords in one comment:
- `Fixes #123, Resolves #456`

More info:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants