Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Lucene and AWS SDK #6

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Conversation

Tombarr
Copy link
Contributor

@Tombarr Tombarr commented Jan 9, 2024

  • Bump to Lucene 9.9
  • Bump to AWS SDK 2.21
  • Update substitutions for GraalVM
  • Replace SimpleFSDirectory with default (MMapDirectory, NIOFSDirectory)
  • Tweak serverless properties for deprecation warning and tuning (EFS encryption, Lambda memory)

Built on mac OS 14.2.1 (M1) with Docker, deployed to AWS via Serverless

Bump to Lucene 9.9 and AWS SDK 2.21
Copy link
Owner

@ArsenyYankovsky ArsenyYankovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There's one thing that serverless validate complains about, otherwise I think it looks good.
I was also thinking if the binary should be committed into this project so that it's easy to deploy without setting up the whole build environment.

serverless.yml Outdated
vpcId: vpc-00690f6e
subnetId1: subnet-039f496e
subnetId2: subnet-0c0af8ea
region: us-east-1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serverless validate complains about this being a duplicate declaration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the duplicate! Copied that over wrong from my project

I was also thinking if the binary should be committed into this project so that it's easy to deploy without setting up the whole build environment.

Ah the change set excludes target/function.zip per .gitignore, should I add it back?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebuild with the latest code and push the new function.zip. Thanks!

Exclude .DS_Store
Remove duplicate region
@ArsenyYankovsky ArsenyYankovsky merged commit ffff899 into ArsenyYankovsky:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants