Preventing reference to the non-existing memory

opennn/config.h

@@ -9,7 +9,9 @@
 
 #define EIGEN_PERMANENTLY_DISABLE_STUPID_WARNINGS
 
-#define _CRT_SECURE_NO_WARNINGS 
+#ifndef _CRT_SECURE_NO_WARNINGS
+#define _CRT_SECURE_NO_WARNINGS
+#endif
 
 // For numeric limits
 

opennn/data_set.cpp

@@ -8420,9 +8420,7 @@ void DataSet::save_data_binary(const string& binary_data_file_name) const
 
     if(regex_search(binary_data_file_name, accent_regex))
     {
-        wstring_convert<codecvt_utf8<wchar_t>> conv;
-        wstring file_name_wide = conv.from_bytes(binary_data_file_name);
-        file.open(file_name_wide, ios::binary);
+        file.open(string_to_wide_string(binary_data_file_name), ios::binary);
     }
     else
     {
@@ -8488,9 +8486,7 @@ void DataSet::load_data_binary()
 
     if(regex_search(data_source_path, accent_regex))
     {
-        wstring_convert<codecvt_utf8<wchar_t>> conv;
-        wstring file_name_wide = conv.from_bytes(data_source_path);
-        file.open(file_name_wide, ios::binary);
+        file.open(string_to_wide_string(data_source_path), ios::binary);
     }
     else
     {
@@ -9350,9 +9346,7 @@ void DataSet::read_csv_1()
 
     if(std::regex_search(data_source_path, accent_regex))
     {
-        std::wstring_convert<std::codecvt_utf8<wchar_t>> conv;
-        std::wstring file_name_wide = conv.from_bytes(data_source_path);
-        file.open(file_name_wide);
+        file.open(string_to_wide_string(data_source_path));
     }else
     {
         file.open(data_source_path.c_str());
@@ -9601,9 +9595,7 @@ void DataSet::read_csv_2_simple()
 
     if(regex_search(data_source_path, accent_regex))
     {
-        wstring_convert<codecvt_utf8<wchar_t>> conv;
-        wstring file_name_wide = conv.from_bytes(data_source_path);
-        file.open(file_name_wide);
+        file.open(string_to_wide_string(data_source_path));
     }else
     {
         file.open(data_source_path.c_str());
@@ -9708,9 +9700,7 @@ void DataSet::read_csv_3_simple()
 
     if(std::regex_search(data_source_path, accent_regex))
     {
-        wstring_convert<std::codecvt_utf8<wchar_t>> conv;
-        wstring file_name_wide = conv.from_bytes(data_source_path);
-        file.open(file_name_wide);
+        file.open(string_to_wide_string(data_source_path));
     }else
     {
         file.open(data_source_path.c_str());
@@ -9842,9 +9832,7 @@ void DataSet::read_csv_2_complete()
 
     if(regex_search(data_source_path, accent_regex))
     {
-        wstring_convert<codecvt_utf8<wchar_t>> conv;
-        wstring file_name_wide = conv.from_bytes(data_source_path);
-        file.open(file_name_wide);
+        file.open(string_to_wide_string(data_source_path));
     }
     else
     {
@@ -10005,9 +9993,7 @@ void DataSet::read_csv_3_complete()
 
     if(regex_search(data_source_path, accent_regex))
     {
-        wstring_convert<codecvt_utf8<wchar_t>> conv;
-        wstring file_name_wide = conv.from_bytes(data_source_path);
-        file.open(file_name_wide);
+        file.open(string_to_wide_string(data_source_path));
     }
     else
     {

opennn/data_set.h

@@ -14,7 +14,6 @@
 
 #include <algorithm>
 #include <cmath>
-#include <codecvt>
 #include <cstdlib>
 #include <ctime>
 #include <exception>
@@ -39,7 +38,11 @@
 #include "correlation.h"
 #include "scaling.h"
 
-//using namespace std;
+#ifdef _WIN32
+#define WIN32_LEAN_AND_MEAN
+#include <Windows.h>
+#endif
+
 using namespace Eigen;
 
 // Filesystem namespace
@@ -64,6 +67,26 @@ using namespace Eigen;
 namespace opennn
 {
 
+#ifdef _WIN32
+    inline std::wstring string_to_wide_string(const std::string& string)
+    {
+        if (string.empty())
+        {
+            return L"";
+        }
+
+        const auto size_needed = MultiByteToWideChar(CP_UTF8, 0, string.data(), (int)string.size(), nullptr, 0);
+        if (size_needed <= 0)
+        {
+            throw std::runtime_error("MultiByteToWideChar() failed: " + std::to_string(size_needed));
+        }
+
+        std::wstring result(size_needed, 0);
+        MultiByteToWideChar(CP_UTF8, 0, string.data(), (int)string.size(), result.data(), size_needed);
+        return result;
+    }
+#endif
+
 /// This class represents the concept of data set for data modelling problems, such as approximation, classification or forecasting.
 
 ///

opennn/language_data_set.cpp

@@ -1479,9 +1479,7 @@ void LanguageDataSet::read_csv_3_language_model()
 
     if (std::regex_search(data_source_path, accent_regex))
     {
-        std::wstring_convert<std::codecvt_utf8<wchar_t>> conv;
-        std::wstring file_name_wide = conv.from_bytes(data_source_path);
-        file.open(file_name_wide);
+        file.open(string_to_wide_string(data_source_path));
     }
     else
     {

opennn/loss_index.cpp

@@ -1039,7 +1039,7 @@ Tensor<type, 1> LossIndex::calculate_numerical_gradient()
 
     for(Index i = 0; i < parameters_number; i++)
     {
-        h = 0.01; // calculate_h(parameters(i));
+        h = static_cast<type>(0.01); // calculate_h(parameters(i));
 
        parameters_forward(i) += h;