-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dom and component focus #978
base: main
Are you sure you want to change the base?
Conversation
b148798
to
f381317
Compare
Greetings, I suppose it's fixed now, although i would like to add that i had to accommodate the Is there any better way to do it? |
Excellent! I am quite busy at the moment. I will take a deeper look as soon as possible. Thank you very much for making this patch! |
c9e0b2b
to
511a294
Compare
There is an issue with the cursor. In I've cross checked it with the previous commits and it seems the issue arises in
#include <ftxui/component/component_options.hpp>
#include "ftxui/component/component.hpp"
#include "ftxui/component/screen_interactive.hpp"
using namespace ftxui;
int main() {
auto screen = ScreenInteractive::Fullscreen();
std::string inp;
auto input = Input(&inp, "input", InputOption::Spacious());
auto display = Renderer(input, [&] {
return vbox({
hbox({
filler(),
vbox({
text("Banner") | center,
}) | size(WIDTH, EQUAL, 40) | border,
filler()
}),
filler(),
input->Render()
| size(WIDTH, EQUAL, 20) | size(HEIGHT, EQUAL, 7) | center
});
});
screen.Loop(display);
} |
Following the approach discussed in #970 to resolve #935