don't keep file open within injectionset (gwastro#4667)

* don't keep file open within injectionset * update docstring
ArthurTolley · Mar 20, 2024 · 9a7ef50 · 9a7ef50
1 parent 62a4921
commit 9a7ef50
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pycbc/inject/inject.py b/pycbc/inject/inject.py
@@ -348,7 +348,6 @@ class _HDFInjectionSet(metaclass=ABCMeta):
 
     Attributes
     ----------
-    filehandler
     table
     static_args
     extra_args
@@ -365,7 +364,6 @@ def __init__(self, sim_file, hdf_group=None, **kwds):
         # open the file
         fp = h5py.File(sim_file, 'r')
         group = fp if hdf_group is None else fp[hdf_group]
-        self.filehandler = fp
         # get parameters
         parameters = list(group.keys())
         # get all injection parameter values
@@ -414,6 +412,7 @@ def __init__(self, sim_file, hdf_group=None, **kwds):
         self.table = self._tableclass.from_kwargs(**injvals)
         # save the extra arguments
         self.extra_args = kwds
+        fp.close()
 
     @abstractmethod
     def apply(self, strain, detector_name, distance_scale=1,