-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support reindexing of files that are directly written to the registry. (
#15) This gives administrators an option to directly write to the registry and bypass the staging directory for bulk updates. It also allows us to easily fix the internal files after manual updates to the user-supplied files.
- Loading branch information
Showing
7 changed files
with
1,209 additions
and
182 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "time" | ||
| "path/filepath" | ||
| "os" | ||
| "encoding/json" | ||
| "net/http" | ||
| ) | ||
|
|
||
| type reindexRequest struct { | ||
| Project *string `json:"project"` | ||
| Asset *string `json:"asset"` | ||
| Version *string `json:"version"` | ||
| User string `json:"-"` | ||
| } | ||
|
|
||
| func reindexPreflight(reqpath string) (*reindexRequest, error) { | ||
| handle, err := os.ReadFile(reqpath) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to read %q; %w", reqpath, err) | ||
| } | ||
|
|
||
| req_user, err := identifyUser(reqpath) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to find owner of %q; %w", reqpath, err) | ||
| } | ||
|
|
||
| request := reindexRequest{} | ||
| err = json.Unmarshal(handle, &request) | ||
| if err != nil { | ||
| return nil, newHttpError(http.StatusBadRequest, fmt.Errorf("failed to parse JSON from %q; %w", reqpath, err)) | ||
| } | ||
|
|
||
| if request.Project == nil { | ||
| return nil, newHttpError(http.StatusBadRequest, fmt.Errorf("expected a 'project' property in %q", reqpath)) | ||
| } | ||
| project := *(request.Project) | ||
| err = isBadName(project) | ||
| if err != nil { | ||
| return nil, newHttpError(http.StatusBadRequest, fmt.Errorf("invalid project name %q; %w", project, err)) | ||
| } | ||
|
|
||
| if request.Asset == nil { | ||
| return nil, newHttpError(http.StatusBadRequest, fmt.Errorf("expected an 'asset' property in %q", reqpath)) | ||
| } | ||
| asset := *(request.Asset) | ||
| err = isBadName(asset) | ||
| if err != nil { | ||
| return nil, newHttpError(http.StatusBadRequest, fmt.Errorf("invalid asset name %q; %w", asset, err)) | ||
| } | ||
|
|
||
| if request.Version == nil { | ||
| return nil, newHttpError(http.StatusBadRequest, fmt.Errorf("expected a 'version' property in %q", reqpath)) | ||
| } | ||
| version := *(request.Version) | ||
| err = isBadName(version) | ||
| if err != nil { | ||
| return nil, newHttpError(http.StatusBadRequest, fmt.Errorf("invalid version name %q; %w", version, err)) | ||
| } | ||
|
|
||
| request.User = req_user | ||
| return &request, nil | ||
| } | ||
|
|
||
| func reindexHandler(reqpath string, globals *globalConfiguration) error { | ||
| request, err := reindexPreflight(reqpath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Configuring the project; we apply a lock to the project to avoid concurrent changes. | ||
| project := *(request.Project) | ||
| project_dir := filepath.Join(globals.Registry, project) | ||
| err = globals.Locks.LockDirectory(project_dir, 10 * time.Second) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to acquire the lock on %q; %w", project_dir, err) | ||
| } | ||
| defer globals.Locks.Unlock(project_dir) | ||
|
|
||
| // Check if this reindexing request is properly authorized. | ||
| perms, err := readPermissions(project_dir) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to read permissions for %q; %w", project, err) | ||
| } | ||
|
|
||
| ok := isAuthorizedToMaintain(request.User, globals.Administrators, perms.Owners) | ||
| if !ok { | ||
| return newHttpError(http.StatusForbidden, fmt.Errorf("user '" + request.User + "' is not authorized to reindex '" + project + "'")) | ||
| } | ||
|
|
||
| // Configuring the asset and version. | ||
| asset := *(request.Asset) | ||
| asset_dir := filepath.Join(project_dir, asset) | ||
| if _, err := os.Stat(asset_dir); err != nil { | ||
| return newHttpError(http.StatusNotFound, fmt.Errorf("cannot access asset directory at %q; %w", asset_dir, err)) | ||
| } | ||
|
|
||
| version := *(request.Version) | ||
| version_dir := filepath.Join(asset_dir, version) | ||
| if _, err := os.Stat(version_dir); err != nil { | ||
| return newHttpError(http.StatusNotFound, fmt.Errorf("cannot access version directory at %q; %w", asset_dir, err)) | ||
| } | ||
|
|
||
| err = reindexDirectory(globals.Registry, project, asset, version) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to reindex project; %w", err) | ||
| } | ||
|
|
||
| summ, err := readSummary(version_dir) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to read the summary file at %q; %w", version_dir, err) | ||
| } | ||
|
|
||
| if summ.OnProbation == nil || !*(summ.OnProbation) { | ||
| // Doing this as late as possible to reduce the chances of an error | ||
| // triggering an abort _after_ the latest version has been updated. | ||
| // I suppose we could try to reset to the previous value; but if the | ||
| // writes failed there's no guarantee that a reset would work either. | ||
| latest := latestMetadata { Version: version } | ||
| latest_path := filepath.Join(asset_dir, latestFileName) | ||
| err := dumpJson(latest_path, &latest) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to save latest version for %q; %w", asset_dir, err) | ||
| } | ||
|
|
||
| // Adding a log. | ||
| log_info := map[string]interface{} { | ||
| "type": "reindex-version", | ||
| "project": project, | ||
| "asset": asset, | ||
| "version": version, | ||
| } | ||
| err = dumpLog(globals.Registry, log_info) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to save log file; %w", err) | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } |
Oops, something went wrong.