Bump Lucene.Net from 4.8.0-beta00016 to 4.8.0-beta00017

[dependabot]

Bumps Lucene.Net from 4.8.0-beta00016 to 4.8.0-beta00017.

Release notes

Sourced from Lucene.Net's releases.

v4.8.0-beta00017

This release contains many bug fixes, performance improvements, and other housekeeping/cleanup tasks. It is the largest update to Lucene.NET 4.8.0 to date.

J2N 2.1 and ICU4N 60.1.0-alpha.436 have had major updates which will lay the groundwork for supporting System.Memory types in Lucene.NET, but those updates will be included in a later release. However, both libraries have had a significant reduction in the number of heap allocations used across their codebases and those improvements have a direct impact on how Lucene.NET performs.

We are including .NET Core support for Lucene.Net.OpenNLP for the first time using the IKVM MavenRefernence feature. The IKVM distribution is quite large and due to disk space limitations of our CI enviornment we had to reference an older version of both IKVM and IKVM.Maven.Sdk. These package references may be upgraded by end users to use a newer version without any risk of breaking changes.

Change Log

Breaking Changes

• Lucene.Net.Util.OfflineSorter: Refactored to base file tracking on FileStream rather than FileInfo, which gives us better control over temp file deletion by specifying the FileOptions.DeleteOnClose option. We also use random access so we don't need to reopen streams over files except in the case of ExternalRefSorter.
• Refactored CharArraySet and CharArrayMap (now CharArrayDictionary) (#762)
• Lucene.Net.Analysis.Kuromoji.Token: Changed these methods into properties: IsKnown() to IsKnown, IsUnknown() to IsUnknown, IsUser() to IsUser.
• Added guard clauses for all TokenAttribute members
• Lucene.Net.Index.IndexReader: De-nested IReaderClosedListener and renamed to IReaderDisposedListener.
• Lucene.Net.Index.IndexWriter: Fixed Dispose() overloads so there is no method signature conflict between the public Dispose(waitForMerges) method and the protected Dispose(disposing) method that can be overridden and called from a finalizer. See #265.
• Lucene.Net.Search.FieldCacheRangeFilter<T>: Changed accessibility from protected internal to private protected. This class was not intended to be subclassed by users. (see #677)
• Lucene.Net.Search.Suggest.Fst.ExternalRefSorter: Changed temp path generation to use FileSupport.CreateTempFile() with named prefix and extension because it more closely matches Lucene and makes the files more easily identifiable.
• Lucene.Net.Util.OfflineSorter: Changed DefaultTempDir() to GetDefaultTempDir().
• Lucene.Net.Analysis.SmartCn.SmartChineseAnalyzer: Changed GetDefaultStopSet() to DefaultStopSet. Marked GetDefaultStopSet() obsolete.
• Lucene.Net.Analysis.Kuromoji.JapaneseAnalyzer: Changed GetDefaultStopSet() and GetDefaultStopTags() to DefaultStopSet and DefaultStopTags, respectively. Marked the old methods obsolete.
• Fixed ArgumentOutOfRange parameters so the message is passed into the 2nd parameter, not the first (which is for argumentName). Fixes #665. Also addressed potential int overflow issues when checking for "index + length must be <= array length".
• Remove .NET 4.5, .NET 4.5.1, and .NET 4.5.2 support and update website framework versions (#650)
• Lucene.Net.IndexWriter.IEvent: Marked internal (as it was in Java). This interface is only used in non-public contexts by Lucene.
• Remove virtual on methods that are being called from constructors (#670 - see PRs linked to this issue)
• Lucene.Net.Util.PriorityQueue<T>: Replaced (int, bool) constructor and removed constructor call to virtual GetSentinelObject() method (#820)
• Lucene.Net.Util: Added ValuePriorityQueue<T> to utilize stack allocations where possible (#826)
• Use factory classes for DirectoryTaxonomyWriter and DirectoryTaxonomyReader to get configs (#847)
• Replicator no longer attempts to deserialize exception types (#968)
• Rename IndexWriter.NextMerge() to GetNextMerge() (#990)
• Lucene.Net.Search.ReferenceContext<T>: Converted to ref struct and reworked TestControlledRealTimeReopenThread.TestStraightForwardDemonstration() to verify functionality (#925)

Bug Fixes

• Lucene.Net.Util.OfflineSorter: Added back original tests using FileInfo and fixed bugs that were preventing the original behavior
• Lucene.Net.Tests.Store.TestRAMDirectory: Fixed teardown to retry file deletion if they are locked by another process.
• Aligned disposable patterns (#746)
• Changed TokenAttribute usage from concrete implementation type to interface type to align with Lucene 4.8.0. We were using the concrete type in several places where it shouldn't have been.
• Lucene.Net.Util.OfflineSorter: Fixed the Sort() and SortPartition() methods so they use the tempDirectory parameter that is passed through the constructor, as was the case in Lucene. Added a constructor overload to specify the directory as a string (a .NET convention).
• Lucene.Net.Analysis.Kuromoji.Util.CSVUtil: Applied SOLR-9413 patch to fix the QuoteEscape() method and add tests. Fixes #660.
• Lucene.Net.Search.Similarities: Statically imported SimilarityBase where appropriate so the Log2 method doesn't have to be qualified (like in Lucene). Fixes #694.
• Fixed a bug where the CharArraySet returned from DefaultStopSet in all analyzers was returning a static writable instance instead of a readonly instance as per the docs.
• Lucene.Net.Tests.Index.TestIndexWriter: Finished port of RandomFailingFieldEnumerable. Fixes #695.
• Lucene.Net.Benchmark.Support.TagSoup.Parser::SetProperty(): Removed duplicate guard clause
• Lucene.Net.Analysis.Cjk.CJKBigramFilter: Changed the value of ALL to set all flags (was 0xff instead of 0xffff). Fixes #657.
• Order of precedence for translation of Remove() method args in FrenchStemmer.cs (#654)
• Fixed Infinite loop in HttpClientBase
• Fixed throw statement in BinaryDictionary
• Fixed use of insecure Path.GetTempFileName in ExternalRefSorter (#651)

... (truncated)

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)