[1.20] Retrieve TEXTURE_MAX_VALUE from compact chunk vertex #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A future version of Embeddium will likely make changes to the value of
TEXTURE_MAX_VALUEin order to backport CaffeineMC/sodium@c674e7b. This will break Oculus code that hardcodes the previous value. To solve this, the value should be retrieved from Embeddium's CompactChunkVertex rather than hardcoding it.Ideally, this change should also be backported to 1.18 & 1.19, as I suspect it can cause issues on those two versions as well.