Refine format according to code review

AssemblyScript · Aug 2, 2023 · b386305 · b386305
1 parent 75e3d5e
commit b386305
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/compiler.ts b/src/compiler.ts
@@ -6610,8 +6610,8 @@ export class Compiler extends DiagnosticEmitter {
         let overrideInstance = overrideInstances[i];
         if (!overrideInstance.is(CommonFlags.Compiled)) continue; // errored
 
-        const overrideSignature = overrideInstance.signature;
-        const originalSignature = instance.signature;
+        let overrideSignature = overrideInstance.signature;
+        let originalSignature = instance.signature;
 
         if (!overrideSignature.isAssignableTo(originalSignature, true)) {
           this.error(

diff --git a/src/types.ts b/src/types.ts
@@ -1053,11 +1053,10 @@ export class Signature {
     let targetThisType = target.thisType;
 
     if (thisThisType != null && targetThisType != null){
-      const compatibleThisType = checkCompatibleOverride ? thisThisType.canExtendOrImplement(targetThisType)
+      const compatibleThisType = checkCompatibleOverride 
+        ? thisThisType.canExtendOrImplement(targetThisType)
         : targetThisType.isAssignableTo(thisThisType);
-      if (!compatibleThisType) {
-        return false;
-      }
+      if (!compatibleThisType) return false; 
     }else if (thisThisType || targetThisType){
       return false;
     }

diff --git a/tests/compiler/class-member-function-as-parameter.ts b/tests/compiler/class-member-function-as-parameter.ts
@@ -1,14 +1,19 @@
 class A {
   foo(): void { }
 }
+
 class B extends A {
   foo(): void { }
 }
+
 function foo(): void { }
+
 function consumeA(callback: (this: A) => void): void { }
 function consumeB(callback: (this: B) => void): void { }
+
 const a = new A();
 const b = new B();
+
 consumeB(a.foo); // shouldn't error
 consumeA(foo);   // should error
 consumeA(b.foo); // should error