Fix migration logic #1172
Merged
Fix migration logic #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinonard
added
astar
Minimum allowed line rate is |
PierreOssun
reviewed
Feb 12, 2024
| @@ -373,17 +373,19 @@ pub mod pallet { | |||
| pub(crate) fn migrate_ledger() -> Result<Weight, Weight> { | |||
| match OldLedger::<T>::drain().next() { | |||
| Some((staker, old_account_ledger)) => { | |||
| let locked = old_account_ledger.locked; | |||
| let old_locked = old_account_ledger.locked; | |||
|
|
|||
| // Old unbonding amount can just be released, to keep things simple. | |||
| // Alternative is to re-calculate this into unlocking chunks. | |||
There was a problem hiding this comment.
Is the comment still relevant ? I guess we are not going for the Alternative
There was a problem hiding this comment.
Not relevant 🙂
But we can delete the whole pallet after this is merged.
PierreOssun
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fix for migration logic to ensure unbonding chunks are released.