-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh action to run e2e tests #1247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermalkaleci
requested review from
Dinonard,
shaunxw,
ashutoshvarma and
PierreOssun
May 24, 2024 19:59
Minimum allowed line rate is |
shaunxw
approved these changes
May 27, 2024
Dinonard
reviewed
May 28, 2024
Comment on lines
+37
to
+38
- name: Build Astar & Shiden runtimes | ||
run: cargo build --release --features astar,shiden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work as you expect it. We don't have per-runtime feature flags implemented.
Perhaps you should use cargo build --release -p astar-runtime -p shiden-runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH action will build Astar & Shiden runtimes and then runs e2e tests using newest runtime. This will give us insight if something changes. This doesn't affect anything on the project, just runs some tests. Although I may change this later when I have a better idea how to deal with snapshot changes.