Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocks updated to use TestDefaultConfig #1410

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mocks updated to use TestDefaultConfig #1410

wants to merge 2 commits into from

Conversation

grbIzl
Copy link

@grbIzl grbIzl commented Jan 16, 2025

Pull Request Summary
Resolves the issue #1350

The following implementations in mocks were wrapped with derive macro to use TestDefaultConfig:

  • pallet_balances::Config
  • pallet_migrations::Config
  • frame_system::Config
  • pallet_timestamp::Config
  • pallet_assets::Config
  • pallet_contracts::Config

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@grbIzl grbIzl added the tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. label Jan 16, 2025
@grbIzl grbIzl mentioned this pull request Jan 16, 2025
Closed
4 tasks
@grbIzl grbIzl marked this pull request as ready for review January 16, 2025 14:30
Dinonard
Dinonard reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a step in the right direction!

There should be more 'deletion' though.
Since we're using default params, there's no need to have all the params defined manually.

@grbIzl
Copy link
Author

grbIzl commented Jan 17, 2025

@Dinonard I cleanup obvious duplications. But I didn't touch the parameters that were redefined with anything meaningful

Dinonard
Dinonard approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

@ermalkaleci ermalkaleci Awaiting requested review from ermalkaleci

@ipapandinas ipapandinas Awaiting requested review from ipapandinas

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grbIzl @Dinonard