Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.ts-it Update #1100

Closed
wants to merge 2 commits into from
Closed

index.ts-it Update #1100

wants to merge 2 commits into from

Conversation

VasaKing
Copy link

Pull Request Summary

This is the updated version of the Italian language of the Portal

Italian update of the index.ts docs
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The words should be used by single quotes instead of double quotes. Also, please make sure linting your code by yarn lint --fix and run it locally before pushing commits.

@VasaKing
Copy link
Author

Ok , I will modify and test it out on my Github account before pushing it again :)

@gluneau
Copy link
Contributor

gluneau commented Feb 1, 2024

I'm suspicious that these two keys have been renamed

  • from nativeWallets to nativeAccount
  • from evmWallets to evmAccount

I can see right here that it is still Wallets and not Account https://github.com/AstarNetwork/astar-apps/blob/main/src/i18n/en-US/index.ts#L180

Either change it in all the files or undo @VasaKing

@gluneau gluneau self-requested a review February 5, 2024 20:32
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kahonnohak
Copy link
Contributor

Hey what's the problem here @VasaKing? You left too long that it has conflict.

@VasaKing VasaKing closed this Feb 27, 2024
@VasaKing VasaKing deleted the patch-1 branch February 28, 2024 00:43
@VasaKing VasaKing restored the patch-1 branch February 28, 2024 00:50
@VasaKing VasaKing deleted the patch-1 branch February 28, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants