Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dApp staking kaizen #1193

Merged
merged 6 commits into from
Feb 21, 2024
Merged

fix: dApp staking kaizen #1193

merged 6 commits into from
Feb 21, 2024

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Feb 19, 2024 •
edited
Loading

Pull Request Summary

  • fix: added docs link to the 'There are too many contract stake entries for the account' error message
  • fix: displaying 'days' or 'day' on the MyStakingCard UI
  • feat: added notification mark for claiming rewards

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • feat: added notification mark for claiming rewards

=Staking=

image

=Project=

image

Changes

  • fix: added docs link to the 'There are too many contract stake entries for the account' error message

=Before=

image

=After=

image

  • fix: displaying 'days' or 'day' on the MyStakingCard UI

(more than 1) days
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e9a1955):

https://astar-apps--pr1193-feat-staking-notific-6kioltjy.web.app

(expires Wed, 28 Feb 2024 05:46:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto changed the title fix: added reference link to the error message fix: dApp staking kaizen Feb 20, 2024
@impelcrypto impelcrypto marked this pull request as ready for review February 20, 2024 09:51
@impelcrypto impelcrypto requested review from bobo-k2, ayumitk, gluneau and Kahonnohak and removed request for bobo-k2 February 20, 2024 09:59
bobo-k2
bobo-k2 requested changes Feb 20, 2024
View reviewed changes
src/components/assets/AnchorLinks.vue Show resolved Hide resolved
src/components/assets/YourProject.vue Outdated Show resolved Hide resolved
bobo-k2
bobo-k2 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kahonnohak
Copy link
Contributor

As I requested please remove the onboarding modals then let's merge tomorrow

@impelcrypto impelcrypto merged commit dfeab9e into main Feb 21, 2024
8 of 9 checks passed
@impelcrypto impelcrypto deleted the feat/staking-notification branch February 21, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluneau gluneau gluneau approved these changes

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@ayumitk ayumitk Awaiting requested review from ayumitk

@Kahonnohak Kahonnohak Awaiting requested review from Kahonnohak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@impelcrypto @Kahonnohak @gluneau @bobo-k2