Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens to be burned calculation fix #1265

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Tokens to be burned calculation fix #1265

merged 2 commits into from
Apr 25, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Apr 23, 2024

Pull Request Summary

Fixed bug in tokens to be burned calculation. The calculation is still not 100% correct, because of an assumption that dApp tier allocation will be the same through all build and earn sub period eras. Fixing this requires a bit more time and it will be done next week.

Before
image

After
image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Apr 23, 2024

Visit the preview URL for this PR (updated for commit df1b9a8):

https://astar-apps--pr1265-fix-tbb-calculation-febq31uw.web.app

(expires Wed, 01 May 2024 07:03:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobo-k2 bobo-k2 merged commit f254b8c into main Apr 25, 2024
9 checks passed
@bobo-k2 bobo-k2 deleted the fix/tbb-calculation branch April 25, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants