Burned rewards calculation #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit f40ec50): https://astar-apps--pr1269-fix-burned-rewards-w3lcu4xd.web.app (expires Fri, 03 May 2024 06:57:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
|
Thanks @bobo-k2 I'll check & verify by manually adding tokens tomorrow! |
gtg7784
reviewed
Apr 25, 2024
|
|
||
| // Determine number of used dApp slots per tier. | ||
| for (let dapp of dappTierRewards.dapps) { | ||
| if (dapp.tierId !== undefined) { |
There was a problem hiding this comment.
if(dapp.tierId)I think it is more better for filtering null too
impelcrypto
approved these changes
Apr 26, 2024
| return result; | ||
| }; | ||
|
|
||
| onMounted(() => { |
There was a problem hiding this comment.
perhaps add 'async' and 'await' here?
There was a problem hiding this comment.
I didn't await here because calculateTotalTokensToBeBurned internally updates ref value and this will cause UI to re-render the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fixed existing 'tokens to be burned' calculation to use real dApp tiers allocation.
The code goes from the first
erain the current period 'tillcurrent_era - 1and calculates how much reward are allocated for empty tiers slots (those are burned rewards). Those calculation is based on real data.Second part of the calculations calculates the same from
current_erauntil lasteraof the current period under assumption that we will have the same dApp tier allocations as in previousera. Since we are looking for total tokens to be burned this is the best we can.The more we are progressing till the end of the current period the more precise calculation will be.
Check list