Governance links section #1402
Merged
Governance links section #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 77d689d): https://astar-apps--pr1402-feat-governance-link-49fptgaf.web.app (expires Wed, 30 Oct 2024 06:59:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
gtg7784
reviewed
Oct 22, 2024
| @@ -126,12 +118,12 @@ export default defineComponent({ | |||
| setup() { | |||
| const { isOpen } = useSidebar(); | |||
| const { isZkEvm, isZkyoto } = useNetworkInfo(); | |||
| const { isEnabled: isGovernanceEnabled, homepageUrl } = useGovernance(); | |||
There was a problem hiding this comment.
imo, it's better to use governanceUrl
|
Wow great! This really gets attention:)
|
impelcrypto
reviewed
Oct 22, 2024
|
Please also add Governance to the mobile menu |
Hi @Kahonnohak I believe I addressed all your comments. Please check, especially the dark theme |
gtg7784
approved these changes
Oct 24, 2024
impelcrypto
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Added
This is currently available on Shibuya
Check list