Account NFT loading fix #1434
Merged
Account NFT loading fix #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 68055f7): https://astar-apps--pr1434-fix-accounts-loading-aomy95ne.web.app (expires Thu, 09 Jan 2025 14:25:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
gtg7784
approved these changes
Jan 3, 2025
impelcrypto
approved these changes
Jan 3, 2025
impelcrypto
added a commit
that referenced
this pull request
Jan 13, 2025
* remove lfgm (#1426) * Feature/replace lfgm (#1428) * update link * add surge gif * update mobile * update desktop * fix mobile style * add tooltip * update image * fix merge errors * Fix for unstaking max amount (#1421) * update polkadot chain icon (#1415) * Inflation chart fix (#1417) * Inflation chart fix * Current inflation calculation and cleanup * Minor bug fixes * Division by zero fix * Fix for unstaking max amount * Better handling unstake warning messages --------- Co-authored-by: Taegeon Alan Go <[email protected]> * Feature/remove deprecated networks (#1430) * remove zKyoto from bridges * remove zKyoto from network selection * remove zKatana code * fix hover styles * restore native bridge * remove zKyoto refs * Account NFT loading fix (#1434) * Account NFT loading fix * Comment out NFT fetching * Don't offer rewards re-staking if staking is not possible (#1436) * Re-stake in last era fix * Can restake check fix * Disable deposit to zkEVM (#1433) * Disable deposit to zkEVM * Disable deposit to zk when connected to L1 * Disabled info message update * fix: redirect to assets page after changing the network (#1435) --------- Co-authored-by: Roy <[email protected]> * Bridge page reorganization (#1437) * Bridge page reorganization * Input placeholder color update --------- Co-authored-by: Taegeon Alan Go <[email protected]> Co-authored-by: Saša Pul <[email protected]> Co-authored-by: Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
When we are implemented account unification on Shibuya we tried to load an account owned NFT from Token API as avatar. If error happens while fetching from the API accounts were not shown.
This PR fixes the above behaviour
UPDATE
Just found out that Bluez is deprecating all their services. Since we are using their API for NFT fetching I commented out the code until find out other provider
Check list