DRAFT : Add MOS functionality to ScopeSim #357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto kl/mos_branch
…into dev_master
… into kl/mos_branch
…into dev_master
…into dev_master
…into dev_master
… Off-by-one artefact in basic_instrument IFU mode
astronomyk
added
enhancement
|
There is a button to mark PR's as draft. I pressed it for you. The button only appears after creating the PR though, that is probably why you missed it: |
2 tasks
…id in automating MOSAIC input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a DRAFT!
Will add text once I know what to write
Tests are locally green except for an off-by-one artefact in the basic-instrument IFU mode, where the WCS conversion thinks [0,139] should be [1,140].