Skip to content

Commit

Permalink
fix: map state having duplicate params and print buffering (#178)
Browse files Browse the repository at this point in the history
  • Loading branch information
vijayvammi authored Jan 9, 2025
1 parent 4bcc13f commit a05af66
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
3 changes: 3 additions & 0 deletions runnable/entrypoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
logger = logging.getLogger(defaults.LOGGER_NAME)


print("") # removes the buffer print


def get_default_configs() -> RunnableConfig:
"""
User can provide extensions as part of their code base, runnable-config.yaml provides the place to put them.
Expand Down
13 changes: 0 additions & 13 deletions runnable/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,19 +156,6 @@ def execution_context(
params = self.resolve_unreduced_parameters(map_variable=map_variable)
logger.info(f"Parameters available for the execution: {params}")

for param_name, param in params.items():
# Any access to unreduced param should be replaced.
# The replacement is the context param
# It is possible that the unreduced param is not created as no upstream step
# has created it yet.
if param.reduced is False:
context_param = param_name
for _, v in map_variable.items(): # type: ignore
context_param = f"{v}_{context_param}"

if context_param in params:
params[param_name].value = params[context_param].value

task_console.log("Parameters available for the execution:")
task_console.log(params)

Expand Down

0 comments on commit a05af66

Please sign in to comment.