Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): Get hostname from SRV record instead of assembling it #22

Merged
merged 4 commits into from
Mar 28, 2024
Merged

fix(windows): Get hostname from SRV record instead of assembling it #22

merged 4 commits into from
Mar 28, 2024

Conversation

jesdazrez
Copy link
Member

The assemble approach produces incorrect hostname values for setups where the hostname doesn't match the computer's name.

@jesdazrez
fix(windows): Get hostname from SRV record instead of assembling it
0b8e9b2 
from the name and domain.

The assemble approach produces incorrect `hostname` values for setups
where the `hostname` doesn't match the computer's name.
@jesdazrez
ref: some clippy fixes
e564780
@jesdazrez
chore: bump env_logger dep
e0e74b2
@jesdazrez
chore: release v0.3.4
1bd1f67
@jesdazrez jesdazrez requested a review from jfro March 28, 2024 16:19
@jesdazrez jesdazrez merged commit 1bd1f67 into develop Mar 28, 2024
6 checks passed
@jesdazrez jesdazrez deleted the jdr/windows_hostname_fix branch March 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfro jfro jfro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesdazrez @jfro