-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nix): drop none-ls formatter #1324
fix(nix): drop none-ls formatter #1324
Conversation
nixd already provides formatting builtin: https://github.com/nix-community/nixd/blob/2c25600cb9c91bc06fe8676c044814dc30435274/nixd/docs/configuration.md?plain=1#L62 <!-- ps-id: 1fa3237e-80c0-4325-a86a-cda8aa832f3a -->
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
We are currently avoiding nixfmt until it becoms stable. See the tracking issue: #883 |
We have nixfmt in 24.11, so it is stable? Also this doesn't replace alejandra it let nixd handle the configuration. People can still configure nixd to use alejandra. It just sets the default. |
My PR sets the formatter as alejandra.As for the stability of nixfmt, check their github repo. They call it not yet stable. :) |
If nixd is active this doesn't work because nixd does the formatting not non-ls. So this is a no-op. Same is true for nil-ls. This pull request is not about alejandra vs nixfmt. You can still use alejandra after that. |
thanks for the pr. whats will be the default formatter after the merge? edit: so i guess it will be nixfmt or nixfmt-rfc-style depends what you have installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, if people want to use something else then the default nixfmt, they can configure it
but the readme needs a update
nixd already provides formatting builtin:
https://github.com/nix-community/nixd/blob/2c25600cb9c91bc06fe8676c044814dc30435274/nixd/docs/configuration.md?plain=1#L62
📑 Description
ℹ Additional Information