feat(sql): disable sqls formatter and add sqlfluff #1336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This should disable the sqls lsp formatter and use sqlfluff instead. Might as well use sqlfluff diagnostics also, I see them beneficial.
This is the issue with sqls at the moment: sqls-server/sqls#149
ℹ Additional Information
This needs thorough testing, since I'm not sure if all works as expected and I lack knowledge to verify on my own due to being new to neovim ecosystem. Especially different combinations of null-ls/conform/nvim-lint/lspconfig community packs.
I disabled cwd in conform due to default settings requiring a config file to be present for the formatter to work. I didn't notice this behavior in null-ls.
There might be an issue with timeouts for formatting, since I've noticed in other github repos people put 1s or even 5s timeout when using sqlfluff.