Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Redux #3

Merged
merged 8 commits into from
Jul 27, 2023
Merged

React Redux #3

merged 8 commits into from
Jul 27, 2023

Conversation

AsumVictor
Copy link
Owner

Milestone 3: React Redux

In this PR, I have added functionalities to display, add and remove book(s) from and to redux store.

Type of change

  • use redux useSeletor in Books.js to display books
  • use redux useDispatch in Book.js to remove a book when the remove button is clicked
  • use redux useDispatch in Form.js to add a book when the submit button is clicked

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • There is no linter error in my code
  • My changes generate no new warnings

Copy link

@joel-kalema joel-kalema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AsumVictor

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request 🛑

pirates-of-the-caribbean-johnny-depp

  • You have submitted a project that has linters that does not pass, make sure you solve them and the ask again for a review

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @joel-kalema in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Copy link

@joel-kalema joel-kalema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AsumVictor

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

Highlights

Your Redux is well connected 👍
The project is running successfully 👍
PR is well descriptive 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @joel-kalema in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@AsumVictor AsumVictor merged commit 647640d into development Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants