Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux and API #4

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Redux and API #4

merged 8 commits into from
Jul 27, 2023

Conversation

AsumVictor
Copy link
Owner

Milestone 4: Redux and API

In this PR, I have added functionalities to fetch and display books data from external API

Type of change

  • use redux createAsyncThunk in BookSlice.js to handle async calls
  • Deleted hardcoded data for books

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • There is no linter error in my code
  • My changes generate no new warnings

Copy link

@anagudelogu anagudelogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: CHANGES REQUIRED ♻️ 🚧

Hi @AsumVictor,
I'm Andres.

While you have done a great job working on this milestone 💻 , there are some issues that you still need to work on to go to the next project. ♻️

You are almost there, keep up the good work! 🚀

Highlights

✅ Great use of Git flow. 💯
✅ Your project is documented professionally. 📜
✅ Descriptive PR title, summary and commit messages. 💬

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/redux/book/bookSlice.js Outdated Show resolved Hide resolved
Copy link

@rotimiazeez rotimiazeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AsumVictor 👏🏽,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Milestone requirements met 😉
  • Clean codebase 👍🏼
  • No linter error ✅️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code. Some of them were simply missed by the previous reviewer, and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me(@rotimiazeez) in your question so I can receive the notification.


As described in the Code reviews limits policy, you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@AsumVictor
Copy link
Owner Author

Thank you very much

@AsumVictor AsumVictor merged commit a7a7857 into development Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants