Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove requires token on mobile #77

Merged
merged 1 commit into from
Mar 5, 2025
Merged

chore: Remove requires token on mobile #77

merged 1 commit into from
Mar 5, 2025
+0 −9

Conversation

jorelosorio
Copy link
Member

@jorelosorio jorelosorio self-assigned this Feb 14, 2025
@jorelosorio jorelosorio mentioned this pull request Feb 14, 2025
Merged
rosvik
rosvik reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@rosvik rosvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should wait with removing this until it has been entirely removed from firestore-configuration (both prod and staging).

@reidzeibel
Copy link
Member

@rosvik will this affect the OMS if we remove the config? will there be any instance where the OMS only allows a ticket to be purchased on the App?

@jorelosorio
Copy link
Member Author

@rosvik will this affect the OMS if we remove the config? will there be any instance where the OMS only allows a ticket to be purchased on the App?

Is not being used right now.

@rosvik
Copy link
Member

rosvik commented Feb 14, 2025

Right, only enabled for AtB: https://github.com/search?q=repo%3AAtB-AS%2Ffirestore-configuration%20requiresTokenOnMobile&type=code

@rosvik rosvik marked this pull request as draft February 19, 2025 14:44
@tormoseng tormoseng marked this pull request as ready for review March 5, 2025 11:52
@tormoseng
Copy link
Member

token restrictions removed in Prod: https://github.com/AtB-AS/firestore-configuration/pull/775

@tormoseng tormoseng requested a review from rosvik March 5, 2025 11:52
rosvik
rosvik approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@rosvik rosvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tormoseng tormoseng merged commit 8c89094 into main Mar 5, 2025
1 check passed
@tormoseng tormoseng deleted the jorelosorio/Remove-token-toggle-restrictions branch March 5, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosvik rosvik rosvik approved these changes

@reidzeibel reidzeibel Awaiting requested review from reidzeibel

Assignees

@jorelosorio jorelosorio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorelosorio @reidzeibel @rosvik @tormoseng