Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide originalPrice when it's not relevant #4729

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix: hide originalPrice when it's not relevant #4729

merged 2 commits into from
Sep 30, 2024

Conversation

rosvik
Copy link
Member

@rosvik rosvik commented Sep 30, 2024

closes https://github.com/AtB-AS/kundevendt/issues/18978

  • Sets originalPrice to 0 when CLEAR_OFFER is called, which fixes the issue from https://github.com/AtB-AS/kundevendt/issues/18978
  • Hides the originalPrice text while loading offers. The normal price is hidden in that state, so it made sense to hide originalPrice as well.

@rosvik rosvik requested a review from reidzeibel September 30, 2024 12:20
@rosvik rosvik changed the title fix: set originalPrice to 0 on CLEAR_OFFER fix: hide originalPrice when it's not relevant Sep 30, 2024
@rosvik rosvik merged commit 1e6c0ab into master Sep 30, 2024
4 checks passed
@rosvik rosvik deleted the rosvik/fix-my-price-striketrough branch September 30, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidzeibel reidzeibel reidzeibel approved these changes

@gorandalum gorandalum Awaiting requested review from gorandalum gorandalum is a code owner

@marius-at-atb marius-at-atb Awaiting requested review from marius-at-atb marius-at-atb is a code owner

@jorelosorio jorelosorio Awaiting requested review from jorelosorio jorelosorio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosvik @reidzeibel