chore: Upgrade react native #5041
Conversation
| @@ -221,7 +221,7 @@ export const Dashboard_TripSearchScreen: React.FC<RootProps> = ({ | |||
| }); | |||
| } | |||
|
|
|||
| const searchTimeButtonRef = useRef(); | |||
| const searchTimeButtonRef = useRef(null); | |||
There was a problem hiding this comment.
As the documentation says about breaking changes https://react.dev/blog/2024/04/25/react-19-upgrade-guide#useref-requires-argument now a value is required, however I am confused about what to use, null or undefined? could you please @gorandalum @rosvik to help me identify what works well in that case?
There was a problem hiding this comment.
I think we should use undefined instead of null but for other cases looks like it need to be null instead of undefined
| children: React.ReactNode; | ||
| } | ||
|
|
||
| export const AccessibilityContextProvider = ({children}: Props) => { |
There was a problem hiding this comment.
@rosvik @gorandalum I was upgrading the react-native that now uses react 19 and there are some changes as listed here https://react.dev/blog/2024/04/25/react-19-upgrade-guide, seems like this is the way to go now, what do you think?
jorelosorio
requested review from
gorandalum,
reidzeibel,
marius-at-atb,
hanne-at-atb,
rosvik and
strandlie
as code owners
Closes https://github.com/AtB-AS/kundevendt/issues/19873
NOTE: Details about some findings in the issue