Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bonus profile screen feedback #5046

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

jorunnl
Copy link
Contributor

@jorunnl jorunnl commented Feb 26, 2025

Resolves feedback from testing and design on:

Specifically:

  • accessibility improvements
  • configurable text from firestore
  • improved error messages
  • Trondheim Bysykkel -> Trondheim City Bike for english

@jorunnl jorunnl self-assigned this Feb 26, 2025
@jorunnl jorunnl marked this pull request as ready for review February 27, 2025 08:50
@jorunnl jorunnl requested a review from Dahly96 February 27, 2025 08:54
Copy link
Contributor

@marius-at-atb marius-at-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jorunnl jorunnl merged commit cdc28a8 into master Feb 27, 2025
4 checks passed
@jorunnl jorunnl deleted the jorunn/fix-bonus-profile-screen-feedback branch February 27, 2025 10:28
Oleninkaa pushed a commit that referenced this pull request Mar 5, 2025
* fix: bonus profile screen feedback

* fix: move log in warning

* fix: use bonusTexts from firestore

* fix: bonus point amount accessibility

* fix: text feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants