Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use PayWithBonusPointsCheckbox for Trondheim bysykkel #5047

Merged

Conversation

jorunnl
Copy link
Contributor

@jorunnl jorunnl commented Feb 27, 2025

Adds use of PayWithBonusPointsCheckbox in BikeStation Bottom sheet.
Will display checkbox if an active BonusProduct for the given operator and form factor exists AND isBonusProgramEnabled is true

@jorunnl jorunnl marked this pull request as ready for review February 27, 2025 10:23
@jorunnl jorunnl self-assigned this Feb 27, 2025
Copy link
Contributor

@marius-at-atb marius-at-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jorunnl jorunnl merged commit 3dbc15f into master Feb 27, 2025
4 checks passed
@jorunnl jorunnl deleted the jorunn/use-pay-with-bonus-pints-checkbox-trondheim-bysykkel branch February 27, 2025 11:30

const [useBonusPoints, setUseBonusPoints] = useState(false);
Copy link
Member

@gorandalum gorandalum Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for later: I would avoid using use as prefix on any variables other than hooks, as it is such an established connotation in React projects.

Oleninkaa pushed a commit that referenced this pull request Mar 5, 2025
* feat: use PayWithBonusPointsCheckbox for Trondheim bysykkel

* fix: feedback, use best practice for usState boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants