Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:rules blocker #5054

Merged
merged 16 commits into from
Mar 4, 2025
Merged

feat:rules blocker #5054

merged 16 commits into from
Mar 4, 2025

Conversation

Dahly96
Copy link
Contributor

@Dahly96 Dahly96 commented Mar 3, 2025

Resolves https://github.com/AtB-AS/kundevendt/issues/20075

Added logic and content to the accept rules page for the rules scooter blocker

image

@Dahly96 Dahly96 requested a review from jorunnl March 3, 2025 14:50
@Dahly96 Dahly96 self-assigned this Mar 3, 2025
@Dahly96 Dahly96 changed the title Magnus/rules blocker feat:Magnus/rules blocker Mar 3, 2025
Copy link
Contributor

@marius-at-atb marius-at-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just one comment that should be addressed before merging.

@marius-at-atb
Copy link
Contributor

Btw we usually don't include our names in PR titles, just in the branch names.

@Dahly96 Dahly96 changed the title feat:Magnus/rules blocker feat:rules blocker Mar 4, 2025
@Dahly96 Dahly96 requested a review from marius-at-atb March 4, 2025 09:50
Copy link
Contributor

@marius-at-atb marius-at-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Dahly96 Dahly96 merged commit a83351a into master Mar 4, 2025
4 checks passed
@Dahly96 Dahly96 deleted the magnus/rulesBlocker branch March 4, 2025 11:30
Oleninkaa pushed a commit that referenced this pull request Mar 5, 2025
* feat:added toggle for deepintegrated operators and the content shown in the scootersheet. With some shmo coponents in the integrated version of the sheet

* added login for scootersheet

* added blocker components and finished locationBlockercomponent

* fixed lint uissue

* removed unused types

* removed fullscreenview wrapper and adda root prop navigation

* removed unused files

* added rulesScreen

* added explenation on openTerms function

* added link to terms from firestore

* added logging for open terms in mobility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants