-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:rules blocker #5054
Merged
Merged
feat:rules blocker #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the scootersheet. With some shmo coponents in the integrated version of the sheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Just one comment that should be addressed before merging.
Btw we usually don't include our names in PR titles, just in the branch names. |
marius-at-atb
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Oleninkaa
pushed a commit
that referenced
this pull request
Mar 5, 2025
* feat:added toggle for deepintegrated operators and the content shown in the scootersheet. With some shmo coponents in the integrated version of the sheet * added login for scootersheet * added blocker components and finished locationBlockercomponent * fixed lint uissue * removed unused types * removed fullscreenview wrapper and adda root prop navigation * removed unused files * added rulesScreen * added explenation on openTerms function * added link to terms from firestore * added logging for open terms in mobility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/AtB-AS/kundevendt/issues/20075
Added logic and content to the accept rules page for the rules scooter blocker