Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate images-client-plugin dependency on image-service #212

Closed
nickdos opened this issue Nov 15, 2016 · 7 comments
Closed

Investigate images-client-plugin dependency on image-service #212

nickdos opened this issue Nov 15, 2016 · 7 comments
Assignees

Comments

@nickdos
Copy link
Contributor

nickdos commented Nov 15, 2016

Find out if the images-client-plugin can work on plain image URLs that are not served from http://images.ala.org.au/.

The background is: international users of the ALA infrastructure use biocache-hubs but don't have image-service serving their images (like ALA does), so the images are usually plain image URLs. So if the images-client-plugin is dependent on image-service, then we either need to add extra config & code to make the dependency optional or else remove the plugin from biocache-hubs and make it a dependency on ala-hubs instead.

@djtfmartin
Copy link
Member

This is something we've discussed in the GBIF developer meetings.

I think the general message that if projects need to support images with an ALA installation that they will need to setup the image-service is accepted as a reasonable approach.

@temi
Copy link
Contributor

temi commented Nov 16, 2016

@djtfmartin @nickdos It is technically possible to show an image on leaflet without tiling capability of image-service. I could implement that feature with a flag to turn it on or off. What do you think?

@nickdos
Copy link
Contributor Author

nickdos commented Nov 17, 2016

I also just noticed that the images-client-plugin has a dependency on lists.ala.org.au - see this issue: AtlasOfLivingAustralia/images-client-plugin#12.

This could also be a problem for current users of ALA code (Spain, at al) if they don't have specieslist-webapp installed.

Should we try and make this part of the code optional?

@temi
Copy link
Contributor

temi commented Nov 17, 2016

@patkyn has added a parameter called addPreferenceButton and it is turned on only for user who are ala admin. However, it does not have an explicit variable to turn it on or off.

https://github.com/AtlasOfLivingAustralia/bie-plugin/blob/master/grails-app/views/species/show.gsp#L973

temi added a commit to AtlasOfLivingAustralia/images-client-plugin that referenced this issue Nov 17, 2016
added ability to show image from url.
This will remove dependency on image service on BIE and Biocache.
temi added a commit to AtlasOfLivingAustralia/bie-plugin that referenced this issue Nov 17, 2016
show images on leaflet with tiling switched off
@temi
Copy link
Contributor

temi commented Nov 17, 2016

@djtfmartin
Copy link
Member

@nickdos yes i agree the lists.ala.org.au dependency should be optional

@djtfmartin
Copy link
Member

Closing historic issue. If this is still a problem, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants