AtlasOfLivingAustralia/biocache-hubs#212 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability to show image from url. This will remove dependency on image service on BIE and Biocache.
|
@temi should be closed now ? Im not sure what the state of this PR is..... |
|
This PR is not merged. It is dependent on issue AtlasOfLivingAustralia/biocache-hubs/issues/212. @nickdos Do you think the issue is still relevant or can be closed? |
|
It would be good to get the PR merged - sorry it was ignored for so long. The conflict is just one file - could you take a quick look and see if it can be fixed easily? If not then we can just abandon it. |
|
@nickdos I checked the code and the merge conflict resolution is not simple. It will also require some testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtlasOfLivingAustralia/biocache-hubs#212
An enhancement for adding image from url