Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit to Master #3

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Initial commit to Master #3

merged 2 commits into from
Jun 30, 2017

Conversation

markwragg
Copy link
Collaborator

Description

  • Initial version. Includes the Send-HipChat function from my module.
  • Have verified locally that the standard set of Pester tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@markwragg markwragg requested a review from lipkau June 30, 2017 12:02
@markwragg
Copy link
Collaborator Author

markwragg commented Jun 30, 2017 •
edited
Loading

FYI AppVeyor won't build this one. I think it's because your initial commit to Master of appveyor.yml says to only build branches master and dev, but the dev branch has been named devleop. I've fixed that in appveyor.yml in this commit, so develop commits should be built after that I think.

@markwragg markwragg requested a review from beaudryj June 30, 2017 14:21
beaudryj
beaudryj reviewed Jun 30, 2017
View reviewed changes
README.md

Attempt to send a message to a room named "My Room" coloured green. Will retry 5 additional times if it fails, waiting 30 seconds between each attempt. Will write verbose output to console.

Send-HipChat -message "my message" -room "My%20Room" -apitoken a1b2c3d4e5f6a1b2c3d4e5f6 -color green -verbose -retry 5 -retrysec 30
Copy link

@beaudryj beaudryj Jun 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have the room get encoded in the code instead of making user URL encode- https://gallery.technet.microsoft.com/scriptcenter/Encoding-and-Decoding-URL-99dc4256

#4

@lipkau lipkau merged commit 83d928b into master Jun 30, 2017
@lipkau
Copy link
Member

lipkau commented Jun 30, 2017

Please update the code with beaudryj 's suggestion in a new PR.
I needed the content on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beaudryj beaudryj beaudryj left review comments

@lipkau lipkau Awaiting requested review from lipkau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markwragg @lipkau @beaudryj