-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for release binaries #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to include version in the release (the same is true for releases on docker hub). it should either be the same as on the docker hub or based on the RuntimeVersion
(which is preferable).
As far as I can see, the DockerHub release contains no more info than a simple timestamp. |
yeah, we considered simplify things on the start and use timestamps (which is both human readable and inremented). after a little bit more thinking, I think now that it's actually would be better (and easier) to use good old semantic versioning. as UPD but I'm not sure whether we need it for the devnet, because of how often it should be deployed. maybe it would be better to use timestamps as versions for the devnet releases and upload them on push into |
Also, we need to release runtime as a wasm. It's needed by Atleta-network/atleta-network-deploy#4 And for the wasm it would be great to have |
Okay, I'll change triggers for this workflow just for |
Related to the Runtime WASM binary (blob)… We can just add this blob to the release archive as well. So my proposition is the following:
|
the purpose of devnet is to be able to check changes immediately. so it should be a rolling release - deploy should happen every time there is a push into |
let's rather trigger wasm releases manually or based on upd |
JFYI there is a tool called subwasm. |
We decide to implement CD release for runtime WASM outside this PR. TODO: #147 This workflow will release |
a02c008
to
21471bb
Compare
TODO @hrls : Edit: done |
21471bb
to
3b7644a
Compare
Runtime release flow moved into new issue
8be6ebc
to
24e080f
Compare
Closes #109